Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various small changes #4722

Merged
merged 4 commits into from Dec 10, 2023
Merged

Various small changes #4722

merged 4 commits into from Dec 10, 2023
+46 −10

Conversation

coot
Copy link
Contributor

@coot coot commented Nov 17, 2023

Description

  • Fixed various typos
  • withSockets: use onException rather than bracket
  • diffusion-policies: added haddock comment
  • peer-selection: organise TracePeerSelection constructors better

Checklist

  • Branch
    • Updated changelog files.
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@coot coot requested a review from bolt12 November 17, 2023 18:35
bolt12
bolt12 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@bolt12 bolt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coot coot enabled auto-merge December 8, 2023 13:33
@coot coot added this pull request to the merge queue Dec 9, 2023
Merged via the queue into master with commit 110e3a4 Dec 10, 2023
8 of 11 checks passed
@coot coot deleted the coot/various-changes branch December 10, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolt12 bolt12 bolt12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Ouroboros Network
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coot @bolt12