Disable PeerSharing completely for NTNV_11-12 #4728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolt12
added
bug
bolt12
force-pushed
the
bolt12/peerSharing-fix
branch
from
1b7375f to
5690925
Compare
coot
reviewed
Nov 24, 2023
bolt12
force-pushed
the
bolt12/peerSharing-fix
branch
from
1c087d5 to
c2d701e
Compare
bolt12
force-pushed
the
bolt12/peerSharing-fix
branch
from
fa6c547 to
896b1a8
Compare
Fixes confusion with pool of peer to share
bolt12
force-pushed
the
bolt12/peerSharing-fix
branch
from
896b1a8 to
25b6e04
Compare
jasagredo
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable PeerSharing completely for NTNV_11-12. I overlooked the fact that the handshake response is also encoded so locally the node will agree on something and send something different over the wire. The fix is to completely disable PeerSharing for older versions.
This also fixes a bug in the pool of peers available to share.