Fixes async demotions to Cold not being noticed #4734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolt12
added
bug
bolt12
force-pushed
the
bolt12/fixColdDemotionsNotNoticed
branch
2 times, most recently
from
ea9a2bf to
479668c
Compare
bolt12
force-pushed
the
bolt12/fixColdDemotionsNotNoticed
branch
from
479668c to
6f45934
Compare
coot
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
This looks good to me. Thanks @bolt12 for the fix.
I think we should also analyse why the tests we have didn't capture the bug in the first place. This could be because we don't have prop_governor_target_known_above in the simulated testnet, which in theory should be able to capture such a bug. However, this can be done as a follow up.
|
Yes there's an issue to write all PeerSelection tests into Testnet cases |
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the bug where when a peer disconnected it could no longer be connected to due to the governor not picking it up.