Skip to content

Fix infinite recursion for websocket #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2021
Merged

Fix infinite recursion for websocket #5

merged 1 commit into from
Dec 9, 2021

Conversation

hrajchert
Copy link
Collaborator

There seem to be a change between 0.13 and 0.14 on how they output the code, but there was an infinite recursion just by evaluating the reconnect.

Screen Shot 2021-12-08 at 13 33 30

@hrajchert hrajchert requested a review from jhbertra December 8, 2021 18:50
jhbertra
jhbertra approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@jhbertra jhbertra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hrajchert hrajchert merged commit 7bd059b into main Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jhbertra jhbertra jhbertra approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hrajchert @jhbertra