updated solid-client for RDF prefixes, but Jest unit tests fail #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSeydoux
approved these changes
Sep 5, 2023
package.json
Outdated
There was a problem hiding this comment.
I would suggest to write down a ticket to migrate the Rollup config to ESM so that we don't remain unaligned with our other repos.
NSeydoux
reviewed
Sep 5, 2023
resources/Vocab/EtlTutorial/Extension/inrupt-common-TEMP_COPY.ttl
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WORK-IN-PROGRESS:
Jest unit tests fail (
npm test), due to the TextEncoder issues we saw long ago.Also, code is pulling in old generated artifacts which use the 'old' HTTP namespace for Schema.org - we should re-generate and publish latest versions (long overdue anyway!).