Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page View Missing parameters #13

Closed
pml-dev opened this issue Jul 22, 2014 · 19 comments
Closed

Page View Missing parameters #13

pml-dev opened this issue Jul 22, 2014 · 19 comments
Labels

Comments

@pml-dev
Copy link

pml-dev commented Jul 22, 2014

Hi in your class "page" for page view tracking missing User Parameters.

It's important for tracking user's navigation.

@ins0
Copy link
Owner

ins0 commented Jul 22, 2014

hey thanks for your action. please look at this branch it should had all requirements that are currently missing in the master branch. currently i don't swap this branch to master because of low response.

#9

@pml-dev
Copy link
Author

pml-dev commented Jul 22, 2014

Thx for reply,

There is lot of parameters i think i w'll modify the class "page" for include user support if i find how to get the goood parameter and value (most complicated)

@ins0
Copy link
Owner

ins0 commented Jul 22, 2014

i would love to hear some feedback 👍

@pml-dev
Copy link
Author

pml-dev commented Jul 23, 2014

i've tried to add user support but it's didn't work. Did you have find the solution on your branch ? or did you take one pageview = one user ?

@ins0
Copy link
Owner

ins0 commented Jul 23, 2014

please look at the createClientID() function on https://github.com/ins0/google-measurement-php-client/blob/master/src/Racecore/GATracking/GATracking.php#L207.

if you don't set a client id by yourself setClientId() the class will try to identify the user and set the correct client id set by google, if this fails a random client id is generated (eg = new user each pageview)

@pml-dev
Copy link
Author

pml-dev commented Jul 23, 2014

No changes look at this screen (my app is on my local machine who isn't public so i'm the only user)

ga-screen1

@ins0
Copy link
Owner

ins0 commented Jul 23, 2014

what kind of app is this?`

@pml-dev
Copy link
Author

pml-dev commented Jul 23, 2014

Symfony 2 app, with ajaxified search engine

@ins0
Copy link
Owner

ins0 commented Jul 23, 2014

as is suggested if the current user doesn't have a cookie from google _ga and your plattform isn't a browser the class can't receive the client id from google so you are responsable to set a unique client id for the current user with setClientId()

@pml-dev
Copy link
Author

pml-dev commented Jul 23, 2014

I Did it and i stroe it in cookie myself look this exemple where i dump the User ID

ga-screen2-1
ga-screen2-2
ga-screen2-3

@ins0
Copy link
Owner

ins0 commented Jul 23, 2014

ah ok now i get the point, sry but it was not clear that you set a client id and for some reason the class ignore this, i will look into this

@pml-dev
Copy link
Author

pml-dev commented Jul 23, 2014

thanks !

@ins0
Copy link
Owner

ins0 commented Jul 23, 2014

you are using the master branch or the parameter branch?

@pml-dev
Copy link
Author

pml-dev commented Jul 23, 2014

actually master

@ins0
Copy link
Owner

ins0 commented Aug 19, 2014

@pml-dev sry for my late response - i refactored the hole class and with my test the duplicate user with same userid/clientid was gone

@pml-dev
Copy link
Author

pml-dev commented Aug 26, 2014

how did it work now ?

@ins0
Copy link
Owner

ins0 commented Aug 26, 2014

as usual the "only" difference is that the campaign class was removed and is now implement into most all tracking types, in my tests with setCliendId the "Live View" only registered 1 User on multiple requests

@pml-dev
Copy link
Author

pml-dev commented Aug 27, 2014

It seems that it works correctly now

@ins0
Copy link
Owner

ins0 commented Aug 27, 2014

👍 thanks for let me notice it was broken

@ins0 ins0 closed this as completed Aug 27, 2014
@ins0 ins0 added the bug label Aug 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants