Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tropo_pyaps3: bugfix for hyp3 product #1061

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Aug 7, 2023

Description of proposed changes

  • tropo_pyaps3: bugfix for hyp3 products in UTM coordinates:

    • calc_delay_timeseries(): remove the call of ut.to_latlon() while preparing the pixel-wised 2D lat/lon matrices, as ut.get_lat_lon() handled the UTM/latlon conversion already since convert coord btw. UTM and lat/lon #1052
  • replace ut.to_latlon() with ut.utm2latlon() as the latter also support non-gdal files, in the following occurrences:

    • tropo_pyaps3.get_bounding_box()
    • utils.utils.prepare_geo_los_geometry()
  • utils.utils0.get_lat_lon(): print out UTM/latlon conversion message, to help future tracking/diagnose

  • prep_hyp3: convert UTM to lat/lon for LAT/LON_REF1/2/3/4

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

+ tropo_pyaps3: bugfix for hyp3 products in UTM coordinates:
   - calc_delay_timeseries(): remove the call of `ut.to_latlon()` while preparing the pixel-wised 2D lat/lon matrices, as `ut.get_lat_lon()` handled the UTM/latlon conversion already in insarlab#1052

+ replace `ut.to_latlon()` with `ut.utm2latlon()` as the later supported more file types, in the following occurrences:
   - tropo_pyaps3.get_bounding_box()
   - utils.utils.prepare_geo_los_geometry()

+ utils.utils0.get_lat_lon(): print out UTM/latlon conversion message, to help future tracking/diagnose

+ prep_hyp3: convert UTM to lat/lon for LAT/LON_REF1/2/3/4
@yunjunz yunjunz merged commit 0cd227b into insarlab:main Aug 8, 2023
4 checks passed
@yunjunz yunjunz deleted the hyp3 branch August 8, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant