Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support azimuth output for solid_earth_tides and bulk_plate_motion #851

Merged
merged 5 commits into from
Sep 22, 2022

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Sep 22, 2022

Description of proposed changes

  • utils.utils0: add more functions to support more flexible ENU to range/azimuth projection

  • solid_earth_tides / bulk_plate_motion:

    • add --comp enu2los / en2az to switch between range / azimuth direction output
    • use utils0.get_unit_vector4comp_of_interest() above to apply the proper projection
  • objects.timeseries.read(): use single indexing to speedup IO

  • add rich to the formal dependency list, as it's lightweight and prints colorful template content, and will be used more.

Reminders

  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

+ solid_earth_tides.py:
   - add --comp enu2los / en2az to switch between range / azimuth direction output
   - use ut.get_unit_vector4comp_of_interest() for --comp projection
   - support date_list text file as input, as an alternative to the TS HDF5 file
   - change set_file as optional arg in calc_solid_earth_tides_timeseries()

+ bulk_plate_motion.py:
   - add --comp enu2los / en2az to switch between range / azimuth direction output
   - use ut.get_unit_vector4comp_of_interest() for --comp projection
   - use lower case "enu" and/or "az" for default output filename
   - set pmm_file as optional arg in calc_bulk_plate_motion()

+ utils.utils0.py:
   - add Coordinate / Orbit sub-section to simplify the Geometry sub-section
   - add definition with example values for the following angles: los_inc_angle, los_az_angle, orb_az_angle, head_angle
   - add los2orbit_azimuth_angle()
   - add azimuth2heading_angle(look_direction) and heading2azimuth_angle(look_direction)
   - add en2az()
   - add get_unit_vector4comp_of_interest()
   - add misregistration2coherence() based on Just & Bamler (1994)

+ utils.utils.prepare_geo_los_geometry(): change the output from head_angle to los_az_angle.

+ smallbaselineApp.plot_result: rm '-u cm' for velocity, as it now has datasets with different units, thus, '-u cm' won't work anymore.

+ del simulation/configSenDesc.txt, as it's not used in the code anymore.
+ objects.timeseries.read(): use single indexing to speedup IO

+ objects.ionex: move plotting-related modules inside plot_ionex() for more independency

+ view: update example usage in the comments for (cli)/view.py
+ tsview: fix the mpl.figure.canvas.set_window_title() bug, as reported and fixed by Jiawei Li

+ use MACRO_CASE for the global variables defined in objects/stack.py and objects/giant.py. Update their usages throughout mintpy repo.

+ other minor codacy suggestions
@yunjunz yunjunz merged commit 73f4e28 into insarlab:main Sep 22, 2022
@yunjunz yunjunz deleted the geoloc branch September 22, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant