Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support display_name for relationships #89

Closed
TribuneX opened this issue Apr 27, 2020 · 1 comment · Fixed by #91 or #94
Closed

Support display_name for relationships #89

TribuneX opened this issue Apr 27, 2020 · 1 comment · Fixed by #91 or #94
Assignees
@insightindustry
Labels
enhancement New feature or request
Milestone
0.5.2

Comments

@TribuneX
Copy link

TribuneX commented Apr 27, 2020 •
edited
Loading

Is seems that there is currently no way to change a name of a relationship attribute:

class Example(Base):
    __tablename__ = "example_system_systems"

    id = Column(sla.Integer, primary_key=True, nullable=False)
    domain_search = relationship("ExampleDomainSearch", supports_json=True)

I want to change the name of the attribute domain_search to domain-search.
@TribuneX
Copy link
Author

I started working on adding this property for relationships. Please check and comment on #91

@insightindustry insightindustry self-assigned this Apr 28, 2020
@insightindustry insightindustry added the enhancement New feature or request label Apr 28, 2020
@insightindustry insightindustry added this to the 0.5.2 milestone Apr 28, 2020
@insightindustry insightindustry linked a pull request Apr 28, 2020 that will close this issue
Add support for display_name property for relationship #91
Merged
insightindustry added a commit that referenced this issue Oct 13, 2020
@insightindustry
Merge pull request #91 from TribuneX/issue89-support-display-name-for…
e2d38df 
…-relationship

Closes issue #89: Add support for display_name property for relationship
@insightindustry insightindustry mentioned this issue Oct 13, 2020
Merged
@insightindustry insightindustry linked a pull request Oct 13, 2020 that will close this issue
PR for v.0.6.0 #94
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@insightindustry insightindustry

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.5.2
2 participants
@TribuneX @insightindustry