Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update KM plots after g_km refactor #56

Closed
edelarua opened this issue Mar 21, 2024 · 2 comments · Fixed by #57 or #62
Closed

Update KM plots after g_km refactor #56

edelarua opened this issue Mar 21, 2024 · 2 comments · Fixed by #57 or #62
Assignees
@edelarua
Labels
enhancement New feature or request sme

Comments

@edelarua
Copy link
Contributor

Update KM plots following g_km refactor in tern (insightsengineering/tern#1210)
@edelarua edelarua added enhancement New feature or request sme labels Mar 21, 2024
@edelarua edelarua self-assigned this Mar 21, 2024
@edelarua edelarua mentioned this issue Mar 21, 2024
Merged
edelarua added a commit that referenced this issue Mar 22, 2024
@edelarua
Update KM plots after g_km refactor (#57)
cf48a6c 
Closes #56
@danielinteractive
Copy link
Contributor

Hi @edelarua I now see
image
in
https://github.com/insightsengineering/biomarker-catalog/actions/runs/8570682159/job/23489132408

@edelarua
Copy link
Contributor Author

edelarua commented Apr 5, 2024

Hi @edelarua I now see

@danielinteractive I see. Probably best to just revert all of the updates until after tern is released to CRAN (which should happen soon). Since there are arguments that were added/deprecated in g_km only one of the stable or development versions will be able to produce output that looks correct/produces no warnings & errors. We probably want that to be the stable version so I will revert all of the changes for now and can reinstate at a later date.

@edelarua edelarua reopened this Apr 5, 2024
@edelarua edelarua mentioned this issue Apr 5, 2024
Merged
edelarua added a commit that referenced this issue May 6, 2024
@edelarua
Revert all KM plot updates (to be added in after CRAN release) (#62)
bb0a1de 
Closes #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edelarua edelarua

Labels
enhancement New feature or request sme
Projects
None yet
Milestone
No milestone
2 participants
@danielinteractive @edelarua