Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need a function to fill in the defaults for formula args? #51

Closed
ddsjoberg opened this issue Nov 15, 2023 · 0 comments · Fixed by #57
Closed

Do we need a function to fill in the defaults for formula args? #51

ddsjoberg opened this issue Nov 15, 2023 · 0 comments · Fixed by #57

Comments

@ddsjoberg
Copy link
Collaborator

ddsjoberg commented Nov 15, 2023

For example, the default are ard_continuous(mtcars, statistics = everything() ~ continuous_variable_summary_fns()). If a user were to change one variable like this:

ard_continuous(mtcars, statistics = age ~ list(mean = \(x) mean(x, na.rm = TRUE)))

Then the remaining variables would not have a summary functions assigned. So we could write a function that first processes what the user passes, and fills in any blanks with the default value. This will be helpful when users only want to change the default for one variable or type of variable, but would require evaluation of the default value each time. ¯\(ツ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant