-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding ard_survival_survfit_diff()
function
#136
Conversation
Code Coverage Summary
Diff against main
Results for commit: fae6d19 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 69 suites 10s ⏱️ Results for commit fae6d19. ♻️ This comment has been updated with latest results. |
FYI @Nolan-Steed I am going to re-write this after we make a few updates to |
CLA Assistant Lite bot ✅ All contributors have signed the CLA |
Unit Test Performance Difference
Additional test case details
Results for commit 5fe9a43 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great Daniel! Just a few typos in the error messages that I noticed.
Co-authored-by: Emily de la Rua <59304861+edelarua@users.noreply.github.com> Signed-off-by: Daniel Sjoberg <danield.sjoberg@gmail.com>
Co-authored-by: Emily de la Rua <59304861+edelarua@users.noreply.github.com> Signed-off-by: Daniel Sjoberg <danield.sjoberg@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Good to go!!
What changes are proposed in this pull request?
ard_survival_survfit_diff()
function for calculating differences in survival estimates. (Need anard_()
for survival estimate differences #126, @)Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #126
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()
ard_*()
function was added, it passes the ARD structural checks fromcards::check_ard_structure()
.ard_*()
function was added,set_cli_abort_call()
has been set.ard_*()
function was added and it depends on another package (such as,broom
),is_pkg_installed("broom", reference_pkg = "cardx")
has been set in the function call and the following added to the roxygen comments:@examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom"", reference_pkg = "cardx"))
devtools::test_coverage()
Reviewer Checklist (if item does not apply, mark is as complete)
devtools::test_coverage()
When the branch is ready to be merged:
NEWS.md
with the changes from this pull request under the heading "# cardx (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).