Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding CIs to SMDs #143

Merged
merged 3 commits into from
May 4, 2024
Merged

adding CIs to SMDs #143

merged 3 commits into from
May 4, 2024

Conversation

ddsjoberg
Copy link
Collaborator

What changes are proposed in this pull request?

  • Style this entry in a way that can be copied directly into NEWS.md. (#, @)

Provide more detail here as needed.

Reference GitHub issue associated with pull request. e.g., 'closes #'


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • If a new ard_*() function was added, it passes the ARD structural checks from cards::check_ard_structure().
  • If a new ard_*() function was added, set_cli_abort_call() has been set.
  • If a new ard_*() function was added and it depends on another package (such as, broom), is_pkg_installed("broom", reference_pkg = "cardx") has been set in the function call and the following added to the roxygen comments: @examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom"", reference_pkg = "cardx"))
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cardx (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

Copy link
Contributor

github-actions bot commented May 4, 2024

badge

Code Coverage Summary

Filename                           Stmts    Miss  Cover    Missing
-------------------------------  -------  ------  -------  ------------------------------------
R/ard_aod_wald_test.R                 77       8  89.61%   36-41, 91, 94
R/ard_car_anova.R                     45       2  95.56%   62, 65
R/ard_car_vif.R                       61       2  96.72%   52, 86
R/ard_effectsize_cohens_d.R           90       2  97.78%   68, 114
R/ard_effectsize_hedges_g.R           84       2  97.62%   68, 119
R/ard_emmeans_mean_difference.R       70       0  100.00%
R/ard_proportion_ci.R                 42       5  88.10%   68-72
R/ard_regression_basic.R              16       1  93.75%   46
R/ard_regression.R                    51       0  100.00%
R/ard_smd_smd.R                       68       5  92.65%   58, 84-87
R/ard_stats_anova.R                   95       0  100.00%
R/ard_stats_aov.R                     36       0  100.00%
R/ard_stats_chisq_test.R              39       1  97.44%   39
R/ard_stats_fisher_test.R             42       1  97.62%   42
R/ard_stats_kruskal_test.R            35       1  97.14%   38
R/ard_stats_mcnemar_test.R            79       2  97.47%   63, 105
R/ard_stats_mood_test.R               48       1  97.92%   46
R/ard_stats_oneway_test.R             38       0  100.00%
R/ard_stats_prop_test.R               84       1  98.81%   43
R/ard_stats_t_test.R                 111       2  98.20%   65, 111
R/ard_stats_wilcox_test.R             98       2  97.96%   65, 117
R/ard_survey_svychisq.R               37       1  97.30%   44
R/ard_survey_svycontinuous.R         193       2  98.96%   169, 179
R/ard_survey_svyranktest.R            51       0  100.00%
R/ard_survey_svyttest.R               50       0  100.00%
R/ard_survival_survdiff.R             89       0  100.00%
R/ard_survival_survfit.R             180       8  95.56%   79-81, 85, 95-97, 247
R/construction_helpers.R              57       6  89.47%   143, 155-159
R/proportion_ci.R                    194      28  85.57%   290, 293, 302-307, 315, 330, 431-454
TOTAL                               2160      83  96.16%

Diff against main

Filename           Stmts    Miss  Cover
---------------  -------  ------  -------
R/ard_smd_smd.R      +13      +4  -5.53%
TOTAL                +13      +4  -0.16%

Results for commit: c2772b2

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented May 4, 2024

Unit Tests Summary

  1 files   64 suites   9s ⏱️
 64 tests  44 ✅ 20 💤 0 ❌
181 runs  149 ✅ 32 💤 0 ❌

Results for commit c2772b2.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 4, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_smd_smd 💀 $0.01$ $-0.01$ ard_proptest_error_messaging
ard_smd_smd 👶 $+0.00$ ard_smd_smd_error_messaging

Results for commit 8fe5255

♻️ This comment has been updated with latest results.

@ddsjoberg ddsjoberg merged commit ec0ae0c into main May 4, 2024
31 checks passed
@ddsjoberg ddsjoberg deleted the ard_smd_smd-adding_ci branch May 4, 2024 22:10
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant