tidyselect firendly #33

pawelru · 2022-10-12T15:44:33Z

linked to https://github.com/insightsengineering/coredev-tasks/issues/398

R CMD TEST

==> devtools::test()

ℹ Loading dunlin
ℹ Testing dunlin
✔ | F W S  OK | Context
✔ |        22 | co_relevels [0.4s]                                                                                                                                                            
✔ |        14 | cut_by_group [0.1s]                                                                                                                                                           
✔ |        21 | dm_explicit_na [0.4s]                                                                                                                                                         
✔ |        17 | pivot [0.2s]                                                                                                                                                                  
⠏ |         0 | propagate                                                                                                                                                                     
Skipping: df1
Updating: df2 with: val
⠙ |         2 | propagate                                                                                                                                                                     
Skipping: df1
Updating: df2 with: val
✔ |         3 | propagate [0.4s]
✔ |        22 | reformat [0.9s]                                                                                                                                                               
✔ |        28 | utils                                                                                                                                                                         

══ Results ═══════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
Duration: 2.5 s

[ FAIL 0 | WARN 0 | SKIP 0 | PASS 127 ]

github-actions · 2022-10-12T15:48:00Z

🧪 $Test coverage: 98.83%$

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  ---------
R/co_relevels.R          17       0  100.00%
R/cut_by_group.R         13       0  100.00%
R/dm_explicit_na.R       35       1  97.14%   58
R/pivot.R                73       0  100.00%
R/propagate.R            22       0  100.00%
R/reformat.R             69       2  97.10%   57, 137
R/utils.R                27       0  100.00%
TOTAL                   256       3  98.83%

Results for commit: 7a8af8e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

github-actions · 2022-10-12T15:48:43Z

Unit Tests Summary

    1 files     7 suites 2s ⏱️
  35 tests   34 ✔️ 1 💤 0 ❌
127 runs 125 ✔️ 2 💤 0 ❌

Results for commit e8db9ce.

♻️ This comment has been updated with latest results.

nikolas-burkoff · 2022-10-12T19:06:02Z

R/dm_explicit_na.R

        dm_update_zoomed()
    }

    if (length(names_fact_col) > 0L) {
      data <- data %>%
        dm_zoom_to(!!tab_sym) %>%
-        mutate(across(names_fact_col, function(x) h_as_factor(x, na_level))) %>%
+        mutate(across(dplyr::all_of(names_fact_col), function(x) h_as_factor(x, na_level))) %>%


hmm odd you have dplyr::all_of but not dplyr::mutate...

tidyselect firendly

28dfd1e

pawelru requested review from BFalquet and nikolas-burkoff October 12, 2022 15:44

BFalquet approved these changes Oct 12, 2022

View reviewed changes

lint

cd32a6c

pawelru added the core label Oct 12, 2022

dplyr:: prefix

e8db9ce

pawelru merged commit c50963b into main Oct 12, 2022

pawelru deleted the tidyselect_friendly branch October 12, 2022 16:17

nikolas-burkoff reviewed Oct 12, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tidyselect firendly #33

tidyselect firendly #33

pawelru commented Oct 12, 2022 •

edited

Loading

github-actions bot commented Oct 12, 2022 •

edited

Loading

github-actions bot commented Oct 12, 2022 •

edited

Loading

nikolas-burkoff Oct 12, 2022

tidyselect firendly #33

tidyselect firendly #33

Conversation

pawelru commented Oct 12, 2022 • edited Loading

github-actions bot commented Oct 12, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Oct 12, 2022 • edited Loading

Unit Tests Summary

nikolas-burkoff Oct 12, 2022

Choose a reason for hiding this comment

pawelru commented Oct 12, 2022 •

edited

Loading

github-actions bot commented Oct 12, 2022 •

edited

Loading

github-actions bot commented Oct 12, 2022 •

edited

Loading