Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3 Transfer data processing functions from chevron to Dunlin #4

Merged
merged 10 commits into from
Feb 24, 2022
Merged

3 Transfer data processing functions from chevron to Dunlin #4

merged 10 commits into from
Feb 24, 2022

Conversation

BFalquet
Copy link
Contributor

@BFalquet BFalquet commented Feb 16, 2022 •
edited
Loading

close #3
(and close #6 )
new preprocessining functions with tests

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2022 •
edited
Loading

Code Coverage Summary

Filename            Stmts    Miss  Cover    Missing
----------------  -------  ------  -------  ---------
R/co_relevels.R        15       0  100.00%
R/cut_by_group.R       13       0  100.00%
R/pivot.R              71       0  100.00%
R/utils.R              27       0  100.00%
TOTAL                 126       0  100.00%

Results for commit: 9e21989

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@wangh107 wangh107 self-requested a review February 16, 2022 17:07
wangh107
wangh107 approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@wangh107 wangh107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with one question:
what is the major difference between mini_pivot_wider and tidyr::pivot_wider except pivot_wider use NSE?

R/coreorder_levels.R Outdated Show resolved Hide resolved
R/cut_by_group.R Show resolved Hide resolved
R/cut_by_group.R Show resolved Hide resolved
R/pivot.R Outdated Show resolved Hide resolved
R/pivot.R Outdated Show resolved Hide resolved
R/pivot.R Show resolved Hide resolved
@BFalquet BFalquet merged commit d9bbb52 into main Feb 24, 2022
@BFalquet BFalquet deleted the 3_transfer-data-processing-functions@main branch February 24, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangh107 wangh107 wangh107 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@BFalquet @wangh107