Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests #69

Merged
merged 3 commits into from
Mar 14, 2023
Merged

add tests #69

merged 3 commits into from
Mar 14, 2023

Conversation

clarkliming
Copy link
Contributor

close #68

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2023

🧪 $Test coverage: 100.00%$

Code Coverage Summary

Filename               Stmts    Miss  Cover    Missing
-------------------  -------  ------  -------  ---------
R/assertions.R            54       0  100.00%
R/co_relevels.R           17       0  100.00%
R/cut_by_group.R          15       0  100.00%
R/dm_explicit_na.R        35       0  100.00%
R/dm_unite.R              31       0  100.00%
R/join_adsub_adsl.R       67       0  100.00%
R/pivot.R                 73       0  100.00%
R/propagate.R             22       0  100.00%
R/reformat.R              72       0  100.00%
R/rules.R                 31       0  100.00%
R/utils.R                 27       0  100.00%
TOTAL                    444       0  100.00%

Results for commit: e7afc94

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2023

Unit Tests Summary

    1 files    11 suites   6s ⏱️
  65 tests   62 ✔️ 3 💤 0
198 runs  194 ✔️ 4 💤 0

Results for commit 0e4c19b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@BFalquet BFalquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for the tests and the improvement of dm_explicit_na. I wonder if this could have an impact on chevron. Please check

@clarkliming
Copy link
Contributor Author

Looks good to me, thank you for the tests and the improvement of dm_explicit_na. I wonder if this could have an impact on chevron. Please check

It won't affect because that condition is never entered

@clarkliming clarkliming merged commit d7a0146 into main Mar 14, 2023
@clarkliming clarkliming deleted the 68_test_coverage@main branch March 14, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

increase reformat test coverage
2 participants