Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user guidance on rename() #199

Merged
merged 19 commits into from
Dec 7, 2022

Conversation

danielinteractive
Copy link
Collaborator

closes #183

@danielinteractive
Copy link
Collaborator Author

@alexjoerich just created this draft PR so we have it on the board already, please continue completing the code on this branch, thanks

Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
Signed-off-by: alexjoerich <73207272+alexjoerich@users.noreply.github.com>
@danielinteractive danielinteractive marked this pull request as ready for review November 29, 2022 16:05
dependabot-preview bot and others added 4 commits November 29, 2022 16:08
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
Signed-off-by: alexjoerich <73207272+alexjoerich@users.noreply.github.com>
@danielinteractive
Copy link
Collaborator Author

@alexjoerich a couple of checks are failing, can you have a look and try to fix them?

@danielinteractive
Copy link
Collaborator Author

@alexjoerich would be cool to finish this one :-) let us know if you need help. thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

badge

Code Coverage Summary

Filename                   Stmts    Miss  Cover    Missing
-----------------------  -------  ------  -------  ------------------------
R/assertthat.R                19       1  94.74%   149
R/calc_cor.R                  25       0  100.00%
R/checkmate.R                  4       0  100.00%
R/connections.R              143     125  12.59%   27-161, 215-287, 356-381
R/differential.R             101       3  97.03%   190, 193, 196
R/dplyr_compatibility.R        3       1  66.67%   23
R/draw_barplot.R              34       0  100.00%
R/draw_boxplot.R              71       5  92.96%   81, 88-89, 106, 109
R/draw_heatmap.R              35       1  97.14%   71
R/draw_scatterplot.R          32       4  87.50%   73-74, 87, 93
R/GeneSpec-class.R            68       0  100.00%
R/graphs.R                   107       3  97.20%   107-109
R/HermesData-class.R          35       4  88.57%   134-137
R/HermesData-methods.R       194       0  100.00%
R/HermesData-validate.R       44       0  100.00%
R/join_cdisc.R                37       0  100.00%
R/normalization.R            100       2  98.00%   194, 223
R/pca_cor_samplevar.R         59       0  100.00%
R/pca.R                       28       0  100.00%
R/quality.R                   75       3  96.00%   109-112
R/top_genes.R                 51       0  100.00%
R/utils.R                     98       0  100.00%
TOTAL                       1363     152  88.85%

Diff against main

Filename    Stmts    Miss    Cover
----------  -------  ------  -------
TOTAL       -        -       -

Results for commit: 2117bb1

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Unit Tests Summary

    1 files    23 suites   1m 43s ⏱️
273 tests 254 ✔️ 19 💤 0
845 runs  822 ✔️ 23 💤 0

Results for commit 05a1966.

♻️ This comment has been updated with latest results.

alexjoerich and others added 4 commits December 6, 2022 13:47
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
Signed-off-by: alexjoerich <73207272+alexjoerich@users.noreply.github.com>
@danielinteractive danielinteractive enabled auto-merge (squash) December 7, 2022 19:24
@danielinteractive danielinteractive merged commit 1cda27e into main Dec 7, 2022
@danielinteractive danielinteractive deleted the 183-improve-user-guidance-for-differentl branch December 7, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve user guidance for differently named assays in source data
2 participants