specify min deps #130
Closed
specify min deps #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelru
requested review from
gmbecker,
edelarua,
Melkiades and
insights-engineering-bot
as code owners
55 tasks
|
Code Coverage SummaryDiff against mainResults for commit: 2a0f4f9 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
averissimo
added a commit
that referenced
this pull request
Sep 15, 2023
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: * #130 ### 🔴 Checklist for PR Reviewer - [ ] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [ ] Package versions are the same or higher than `main` - [ ] Package list is the same - Only exception is `rmarkdown` (may have been removed on `Suggests`) - [ ] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [ ] Added entry to `NEWS.md` - [ ] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [ ] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * [x] `formatters` release of the next version and update DESCRIPTION accordingly * `fmt_config` is required and only available at `formatters@main` atm * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action --------- Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP