Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logo #172

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Update logo #172

merged 2 commits into from
Oct 19, 2023

Conversation

edelarua
Copy link
Contributor

Closes #168

To merge after release.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023 •
edited
Loading

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ---------------------------------------------------------
R/paginate_listing.R        47       1  97.87%   101
R/rlistings_methods.R      101      14  86.14%   39, 54, 58, 140-143, 146, 230-236
R/rlistings.R              159      20  87.42%   156-157, 160-161, 200-202, 366-369, 373-376, 405, 409-412
TOTAL                      307      35  88.60%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 5890036

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023 •
edited
Loading

Unit Tests Summary

  1 files    4 suites   9s ⏱️
31 tests 24 ✔️ 7 💤 0 ❌
79 runs  70 ✔️ 9 💤 0 ❌

Results for commit 5890036.

♻️ This comment has been updated with latest results.

Melkiades
Melkiades approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm Emily! Thanks, it was already submitted, so the logo will be present in the next release and on gitHub.

@Melkiades Melkiades enabled auto-merge (squash) October 19, 2023 14:03
@Melkiades Melkiades merged commit edfa515 into main Oct 19, 2023
25 checks passed
@Melkiades Melkiades deleted the 168_update_logo@main branch October 19, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Melkiades Melkiades Melkiades approved these changes

@insights-engineering-bot insights-engineering-bot Awaiting requested review from insights-engineering-bot

Assignees
No one assigned
Labels
blocked sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update logo
2 participants
@edelarua @Melkiades