-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reffn_at_path<-
for postprocessing
#219
Comments
@anajens I've added the
We can then add them
|
Thanks so much @gmbecker, this looks great! One question - does this also work for column footnotes? I tried the code below but I'm getting an error:
I'm trying to make a table that looks like this:
|
Hi Jana. Column references are not yet supported but they will be and when
they are, that is how you will create them. They're listed under a separate
issue that is still open
…On Thu, Aug 12, 2021 at 6:28 AM Jana Stoilova ***@***.***> wrote:
Thanks so much @gmbecker <https://github.com/gmbecker>, this looks great!
One question - does this also work for column footnotes? I tried the code
below but I'm getting an error:
> fnotes_at_path(tb1, rowpath = NULL, colpath = c("ARM", "C: Combination")) <- c("test col footer")
Error in (function (classes, fdef, mtable) :
unable to find an inherited method for function ‘fnotes_at_path<-’ for signature ‘"TableTree", "NULL"’
I'm trying to make a table that looks like this:
A: Drug X B: Placebo C: Combination {1}
---------------------------------------------------------------------------------------------
WHITE 14 (11.6%) 14 (13.2%) 18 (14%)
...
---------------------------------------------------------------------------------------------
{1} - test col footer
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#219 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG53MMMIJCPV5I6YUO5SLTT4PEBNANCNFSM5AWERBZA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
According to the docs, |
Yes, correct. I'm working on implementing that now. That is a placeholder
for what will work, so I didn't forget to to change the docs later. Sorry
about the confusion.
…On Thu, Aug 12, 2021 at 1:44 PM Jana Stoilova ***@***.***> wrote:
According to the docs, rowpath does take NULL. I guess it's just a
placeholder for now?
https://github.com/Roche/rtables/blob/78f8c7a3b89b74f55e0db38deb67b576a9a2192f/R/tree_accessors.R#L2265
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#219 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG53MJZ5JLSVV7EWMNV76DT4QXCFANCNFSM5AWERBZA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
* Exp allow a/cfuns + splfuns to accept .prev_splvals arg. #203 dev vbump * Fix bug where names weren't showing up for .prev_splvals. #203 dev vbump * Fix off-by-one error in pagination, sep in txt export. Fixes #213 * add experimental fnotes_at_path function. Needs tests. #219. vbump * Exp allow a/cfuns + splfuns to accept .prev_splvals arg. #203 dev vbump * Fix bug where names weren't showing up for .prev_splvals. #203 dev vbump * Fix off-by-one error in pagination, sep in txt export. Fixes #213 * add experimental fnotes_at_path function. Needs tests. #219. vbump * Run GH actions for all branches * Working fntes_at_path with tests. Closes #219. dev vbump * col ref footnote support. related to #219. Closes #187. dev vbump * Support and tests for trim_levels_to_map. closes #203. Devel vbump. * cell_values and value_at methods for Row objects. closes #210. dev vbump * Trim outer levels to trim_levels_in_groups by deflt. #236 dev vbump * Cleanup, additional tests, and fix bugs uncovered by new tests. * Add NEWS entries, prepare for merge into main Co-authored-by: dinakar29 <26552821+dinakar29@users.noreply.github.com>
as discussed with @anajens
The text was updated successfully, but these errors were encountered: