Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review teal.slice documentations before release #314

Closed
donyunardi opened this issue May 31, 2023 · 4 comments
Closed

Review teal.slice documentations before release #314

donyunardi opened this issue May 31, 2023 · 4 comments
Labels

Comments

@donyunardi
Copy link
Contributor

donyunardi commented May 31, 2023

Summary

Related with insightsengineering/nestdevs-tasks#25
We want to perform teal.slice release to introduce the first milestone of the filter panel upgrade.

Pre-req

Acceptance Criteria

  • Review and test roxygen examples
  • Review vignettes
  • Update NEWS
  • Update README (if applicable)
  • Review DESCRIPTION file (i.e. dependency versions, etc)
@chlebowa
Copy link
Contributor

chlebowa commented Jun 2, 2023

Example apps were added recently to illustrate the inner workings of FilterState and its children as well as DFFilterStates. Since then the api has changed, which was accompanied by making several methods private. $format has also changed. The example apps must be caught up to these changes, they may not even work properly now. This can be done on filter_panel_refactor@main.

@gogonzo
Copy link
Contributor

gogonzo commented Jun 15, 2023

From @chlebowa
Several changes have been made during the refactor without amending documentation. This must be done before merging to main.

examples

FilteredData

#' - `logical`: variable of type `logical`, e.g. `ADSL$TRT_FLAG`
#'      exactly one option must be selected, `TRUE` or `FALSE`

👆 logical need not select one


teal_slice

@param multiple (`logical(1)`)\cr

👆 inconsistent format; see also

#' Special consideration is given to two fields: `fixed` and `locked`.

👆 rewrite after multiple


examples

  • example apps in FilterState* and FilterStatesDF to define states with teal_slice


...

@pawelru
Copy link
Contributor

pawelru commented Aug 8, 2023

Hi @gogonzo @chlebowa can you please close it if it's finished?

@gogonzo
Copy link
Contributor

gogonzo commented Aug 9, 2023

Done

@gogonzo gogonzo closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants