Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose na_str argument in analyze/summarize functions #1070

Closed
edelarua opened this issue Sep 27, 2023 · 2 comments · Fixed by #1071
Closed

Expose na_str argument in analyze/summarize functions #1070

edelarua opened this issue Sep 27, 2023 · 2 comments · Fixed by #1071
Assignees
@edelarua
Labels
enhancement sme

Comments

@edelarua
Copy link
Contributor

edelarua commented Sep 27, 2023 •
edited
Loading

Add the na_str argument to all tern analyze/summarize wrapper functions which take the na_str argument.
@edelarua edelarua self-assigned this Sep 27, 2023
@Melkiades
Copy link
Contributor

I think we should also deprecate the name na_level in favor of na_str for simplicity

@khatril
Copy link
Contributor

khatril commented Sep 28, 2023

@BFalquet @clarkliming

@edelarua edelarua mentioned this issue Sep 28, 2023
Merged
Melkiades pushed a commit that referenced this issue Oct 6, 2023
@edelarua @github-actions
Expose na_str argument in analyze/summarize functions (#1071)
ac289c3 
Closes #1070

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edelarua edelarua

Labels
enhancement sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose na_str argument in analyze/summarize functions insightsengineering/tern
3 participants
@Melkiades @edelarua @khatril