Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add compute query to get memory and cpu defaults #74

Merged
merged 3 commits into from
Jun 15, 2023
Merged

add compute query to get memory and cpu defaults #74

merged 3 commits into from
Jun 15, 2023

Conversation

MSamman
Copy link
Contributor

@MSamman MSamman commented May 11, 2023

No description provided.

@MSamman MSamman marked this pull request as ready for review June 14, 2023 00:28
@MSamman
Copy link
Contributor Author

MSamman commented Jun 14, 2023

@mattrasmus this is ready for a review whenever you get a chance!

@mattrasmus
Copy link
Collaborator

@mattrasmus this is ready for a review whenever you get a chance!

Great. Will review now. Apologies for the delay.

@mattrasmus
Copy link
Collaborator

LGTM and tests pass. I'll merge. Thanks for contributing!

mattrasmus
mattrasmus approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@mattrasmus mattrasmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattrasmus mattrasmus merged commit fb83b0b into insitro:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielecook danielecook danielecook left review comments

@mattrasmus mattrasmus mattrasmus approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MSamman @mattrasmus @danielecook