Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MN-631: validate version contract #50

Closed
wants to merge 6 commits into from

Conversation

sansaian
Copy link
Contributor

@sansaian sansaian commented Aug 3, 2020

- What I did
validate contract version https://insolar.atlassian.net/wiki/spaces/DEV/pages/1508409428/heavy+node
- How I did it
add const with version
- How to verify it
run all test and starting mainnet and observer with auth service
- Description for the changelog

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2020

Codecov Report

Merging #50 into master will increase coverage by 0.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   15.30%   15.90%   +0.59%     
==========================================
  Files           7        7              
  Lines        1006     1006              
==========================================
+ Hits          154      160       +6     
+ Misses        844      833      -11     
- Partials        8       13       +5     
Impacted Files Coverage Δ
...solar/mainnet/application/appfoundation/helpers.go 10.52% <0.00%> (ø)
...et/application/builtin/contract/deposit/deposit.go 2.64% <0.00%> (+2.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf824a5...5572daa. Read the comment docs.

@MikhailPopov MikhailPopov force-pushed the MN-631-validate-version-contract branch from 33c7cff to 78172ea Compare August 4, 2020 11:55
@sansaian sansaian closed this Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants