MN-655: added transaction type #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MN-651: split spec files * MN-651: return temporary admin methods in api-exported.yaml
Codecov Report
@@ Coverage Diff @@
## MN-574-1 #51 +/- ##
===========================================
Coverage ? 14.95%
===========================================
Files ? 7
Lines ? 1070
Branches ? 0
===========================================
Hits ? 160
Misses ? 897
Partials ? 13 Continue to review full report at Codecov.
|
megge-dream
suggested changes
Aug 4, 2020
megge-dream
approved these changes
Aug 4, 2020
LinnikD
approved these changes
Aug 4, 2020
Hirama
approved these changes
Aug 4, 2020
* MN-662: fix TestMigrationDaemonTransferDeposit * MN-662: fix TransferDeposit tests
� Conflicts: � application/api/spec/api-exported-internal.yaml � application/api/spec/api-exported.yaml � vendor/github.com/ugorji/go/codec/LICENSE
pavlushev
added a commit
that referenced
this pull request
Aug 10, 2020
* MN-581: create method deposit.transferToDeposit * MN-581: create method deposit.transferToDeposit * MN-591: add `deposit.createFund` method (#39) * PENV-346: add hash to full pulse * MN-591: add `deposit.createFund` method * MN-591: refactor method names and remove redundant constructor parameter * MN-591: switch to master * MN-591: cleanup after rebase Co-authored-by: Maria Zubareva <maria.zubareva@insolar.io> * MN-581: create method deposit.transferToDeposit * resolve conflict * resolve conflict * MN-636: add method `account.transferToDeposit` (#42) * MN-636: add method `account.transferToDeposit` * MN-636: rename `TransferToDeposit` to `ReallocateToDeposit` * MN-636: add balance checks to functest * MN-655: added transaction type (#51) * MN-651: split spec files (#46) * MN-651: split spec files * MN-651: return temporary admin methods in api-exported.yaml * MN-655: added transaction type * MN-651: reset api-exported.yaml to v1.1.1 (#48) * MN-655: rename TransferType.go to the transfer_type.go * MN-662: fix TestMigrationDaemonTransferDeposit (#52) * MN-662: fix TestMigrationDaemonTransferDeposit * MN-662: fix TransferDeposit tests Co-authored-by: Alexey Zhunin <zhunin.a.u@gmail.com> Co-authored-by: Mikhail Popov <53470434+MikhailPopov@users.noreply.github.com> Co-authored-by: Alexey Zhunin <zhunin.a.u@gmail.com> Co-authored-by: Maria Zubareva <maria.zubareva@insolar.io> Co-authored-by: Mikhail Popov <53470434+MikhailPopov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what I did:
In collectors, we can understand where the call came from and determine the appropriate type of transaction.