Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PENV-128: fix unit test TestRequester #8

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

pavel-moskovkin
Copy link
Contributor

- What I did
Fix slow test TestRequester_UserShouldNotPassInvalidUrl
- How to verify it
Run unit tests
- Description for the changelog
Fix slow test TestRequester_UserShouldNotPassInvalidUrl

@pavel-moskovkin
Copy link
Contributor Author

Successful Slow Tests Run with the same changes in insolar/insolar: https://teamcity.insolar.io/viewLog.html?buildId=241526&buildTypeId=AwesomeCi_NightlyTests_SlowTests

@codecov-io
Copy link

Codecov Report

Merging #8 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   15.30%   15.30%           
=======================================
  Files           7        7           
  Lines        1006     1006           
=======================================
  Hits          154      154           
  Misses        844      844           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84706ff...8ba0a24. Read the comment docs.

Copy link
Contributor

@Tsovak Tsovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job there

@megge-dream megge-dream merged commit 05ef645 into master Apr 6, 2020
@megge-dream megge-dream deleted the PENV-128-fix-unit-test branch April 6, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants