-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis matrix #225
Travis matrix #225
Conversation
I think that this PR is still useful |
We are going to enlarge the travis matrix a lot for testing multiple dependencies versions. Anyway, If you really want to split tests we can try to use only the travis jaml file in order to keep things simple. |
ael:
ok so I will try to put everything inside.
ok, I'll do boyska |
Ok, done. By the way, I enabled "concurrent builds" on travis (I don't know why it wasn't) so now it is somewhat faster. |
On 03/04/2016 04:23 PM, BoySka wrote:
I like it much more now
Good Anyway what about |
ael:
what do you mean? sorry, but I have not understood! |
On 03/05/2016 11:11 PM, BoySka wrote:
with this PR you've folded the I was asking when it will be the case that the |
You're right, I don't know why I did that, but now I removed it and everything seems to work fine. |
waiting for review on boyska#2 |
On travis there is a job related to no-envvars case that perform only the installation |
ael:
you're right but... can you understand why? |
On my PR this do not happen: https://travis-ci.org/ael-code/libreant/builds/114050261. As stated in the official travis docs about matrix.include:
So you've populated the matrix with python2.7 job and then you are adding other stuff with I think I've the solution for this problem, but since we have a lot of PR opened, I would like to proceeds as follows:
|
ael:
oh, that's nice, they are using a declarative format as if it was an
ok, I took the commit you proposed in a PR on my repo (could net accept boyska |
rebase? |
2f8f354
to
91c46d6
Compare
I'm reintroducing |
I've used your inline patter in another project and I discovered that is wrong :)
when We should move to something like:
|
Forget it. Also my solution is wrong. |
oke... This pattern should work:
I did not find anything shorter |
you're right, I will fix it asap |
no, wait; does the |
c8f2f03
to
b83561d
Compare
Assuming that it works, I have used it. |
I think that it will be better if we use the if-return pattern everywhere. For example we are interested also in the exit code of |
Creates a "build matrix" which makes the different tests parallelizable and more "to the point" (ie: sphinx and flake8 are not installed when running unit tests)
refs #212