Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nirbhay/IAM Server Certificate/Certificates #511

Merged
merged 14 commits into from
Oct 28, 2021
Merged

Conversation

Nirbhay1997
Copy link
Contributor

@Nirbhay1997 Nirbhay1997 commented Aug 16, 2021

Description

Please describe what this change achieves. Ensure you have read the Contributing to InSpec AWS document before submitting.

Issues Resolved

List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant

Check List

Please fill box or appropriate ([x]) or mark N/A.

@Nirbhay1997 Nirbhay1997 requested a review from a team as a code owner August 16, 2021 08:55
Signed-off-by: nirbhay1997 <nkumar@progress.com>
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
Copy link
Contributor

@soumyo13 soumyo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the integration tests.

Nirbhay Kumar added 4 commits September 8, 2021 08:41
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Copy link
Contributor

@soumyo13 soumyo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nirbhay1997 Nirbhay1997 requested a review from a team September 8, 2021 06:53
@Nirbhay1997 Nirbhay1997 changed the title Added support to audit Server Certificate/Certificates Nirbhay/IAM Server Certificate/Certificates Sep 8, 2021
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@IanMadd
Copy link
Contributor

IanMadd commented Sep 13, 2021

There's no documentation here.

Nirbhay Kumar and others added 3 commits October 22, 2021 08:29
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
Nirbhay Kumar and others added 2 commits October 27, 2021 13:03
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@soumyo13 soumyo13 merged commit c5594f2 into main Oct 28, 2021
@soumyo13 soumyo13 deleted the nirbhay/server_certificate branch October 28, 2021 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants