Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exists? method to google_compute_address #138

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

ivantsepp
Copy link
Contributor

This adds an exists? method to google_compute_address. The documentation for google_compute_address shows:

describe google_compute_address(project: 'chef-inspec-gcp', location: 'us-west2', name: 'gcp-inspec-test') do
        it { should exist }
end

but that will fail because there is no exists? method. This PR fixes that.

I'm not sure if this is affected by the magic modules I see in the codebase. Also unsure if y'all would prefer if we fix the documentation since there's already an address_ip_exists method.

Let me know if this is the right approach and I can also look into adding tests!

Signed-off-by: Ivan Tse <ivan.tse1@gmail.com>
Copy link

@skpaterson skpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome and many thanks for this @ivantsepp ! Also, apologies for the delay in approval.

@skpaterson skpaterson merged commit 7fcefb4 into inspec:master Apr 30, 2019
@ivantsepp
Copy link
Contributor Author

No worries at all! Thank you for taking the time to look/review this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants