Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes according to issues: #19, #20, #21 and #22. #24

Merged
merged 1 commit into from
Jun 11, 2018
Merged

Fixes according to issues: #19, #20, #21 and #22. #24

merged 1 commit into from
Jun 11, 2018

Conversation

skpaterson
Copy link

  • Ensure resources have consistent exists methods.
  • Corrected a coupld of arguments in example doc strings.

Signed-off-by: Stuart Paterson spaterson@chef.io

Fixes according to issues: #19, #20, #21 and #22.
9a92acc 
* Ensure resources have consistent exists methods.
* Corrected a coupld of arguments in example doc strings.

Signed-off-by: Stuart Paterson <spaterson@chef.io>
miah
miah approved these changes Jun 11, 2018
View reviewed changes
Copy link
Contributor

@miah miah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @skpaterson

clintoncwolfe
clintoncwolfe approved these changes Jun 11, 2018
View reviewed changes
Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks @skpaterson !

@clintoncwolfe clintoncwolfe merged commit 461df50 into master Jun 11, 2018
@clintoncwolfe clintoncwolfe deleted the node-pool-instance-group-fixes branch June 11, 2018 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintoncwolfe clintoncwolfe clintoncwolfe approved these changes

@miah miah miah approved these changes

@chris-rock chris-rock Awaiting requested review from chris-rock

@jquick jquick Awaiting requested review from jquick

@jerryaldrichiii jerryaldrichiii Awaiting requested review from jerryaldrichiii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skpaterson @miah @clintoncwolfe