Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instance helpers, managed zone helpers #259

Merged
merged 6 commits into from
May 19, 2020

Conversation

slevenick
Copy link
Collaborator

Description

Fix several helper methods. Defaults on dns managed zone signing keys

Issues Resolved

#258
#257

modular-magician and others added 3 commits May 8, 2020 18:02
* Add region_backend_service portName

* add port_name attribute to test cases

* add update from http to https for ilbUpdates

Co-authored-by: cynful <cynful@users.noreply.github.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: cynful <cynful@users.noreply.github.com>
…88) (#397)

Signed-off-by: Modular Magician <magic-modules@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@slevenick slevenick requested a review from a team as a code owner May 9, 2020 14:48
@skpaterson
Copy link

The build seems to be failing on this one @slevenick

Signed-off-by: Modular Magician <magic-modules@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@slevenick
Copy link
Collaborator Author

The build seems to be failing on this one @slevenick

Fixed!

Copy link

@skpaterson skpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks @slevenick !

@skpaterson skpaterson added the Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. label May 19, 2020
@skpaterson skpaterson merged commit 815ba19 into inspec:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants