Add support for google_compute_vpn_tunnels and google_compute_vpn_tunnel #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jnahelou <nahelou.j@sfeir.com>
Signed-off-by: jnahelou <nahelou.j@sfeir.com>
Signed-off-by: jnahelou <nahelou.j@sfeir.com>
skpaterson
reviewed
Nov 22, 2018
There was a problem hiding this comment.
This is fantastic work @jnahelou ! Would you mind also adding some documentation and we can get this merged?
Signed-off-by: jnahelou <nahelou.j@sfeir.com>
|
Following subnetworks example, I added vpn_tunnels and vpn_tunnel documentations. |
skpaterson
approved these changes
Nov 23, 2018
skpaterson
pushed a commit
that referenced
this pull request
Jan 24, 2019
Initial autogeneration of Spanner instance in Terraform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow users to perform validation of VPN connections.
I updated integrations tests to setup create a VPN tunnel to a GCP static ip address. This link can't be established but help us to validate changes.