Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for EOL Ruby 2.5 #5783

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Remove support for EOL Ruby 2.5 #5783

merged 1 commit into from
Jan 10, 2022

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Jan 1, 2022

With the release of Ruby 3.1, Ruby 2.5 is now EOL. We should not be supporting an EOL release of Ruby.

Signed-off-by: Tim Smith tsmith@chef.io

With the release of Ruby 3.1, Ruby 2.5 is now EOL. We should not be supporting an EOL release of Ruby.

Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50 tas50 requested review from a team as code owners January 1, 2022 04:00
@netlify
Copy link

netlify bot commented Jan 1, 2022

✔️ Deploy Preview for chef-inspec canceled.

🔨 Explore the source changes: 48ff852

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-inspec/deploys/61cfd1f44b98f00008c07131

@chef-expeditor
Copy link
Contributor

chef-expeditor bot commented Jan 1, 2022

Hello tas50! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@sonarcloud
Copy link

sonarcloud bot commented Jan 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@clintoncwolfe clintoncwolfe merged commit 2bedb1a into main Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants