Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFINSPEC-79: Add linux container resource #5921

Merged
merged 8 commits into from
Mar 19, 2022
Merged

Conversation

ahasunos
Copy link
Contributor

Signed-off-by: Sonu Saha sonu.saha@progress.com

Description

ISSUE: CFINSPEC-79 — Add linux container resource.
'lxc' resourc allows testing if a linux container exists or is in running status.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Changes made to existing file:

  • test/helpers/mock_loader.rb

New files included for lxc resource:

  • docs-chef-io/content/inspec/resources/lxc.md
  • lib/inspec/resources/lxc.rb
  • test/fixtures/cmd/lxcinfo
  • test/unit/resources/lxc_test.rb

Checklist:

  • I have read the CONTRIBUTING document.

@ahasunos ahasunos requested a review from a team as a code owner March 11, 2022 11:59
@ahasunos ahasunos self-assigned this Mar 11, 2022
@ahasunos ahasunos requested a review from a team as a code owner March 11, 2022 11:59
@netlify
Copy link

netlify bot commented Mar 11, 2022

✔️ Deploy Preview for chef-inspec ready!

🔨 Explore the source changes: 73920f7

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-inspec/deploys/6231c77315c1f80008e91b67

😎 Browse the preview: https://deploy-preview-5921--chef-inspec.netlify.app/inspec/resources/lxc

@github-actions github-actions bot added the Documentation ZH multi-repo label for the docs-team label Mar 11, 2022
@chef-expeditor
Copy link
Contributor

Hello ahasunos! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@ahasunos ahasunos added the Component: Core Resources Resources shipped with InSpec. label Mar 11, 2022
lib/inspec/metadata.rb Outdated Show resolved Hide resolved
lib/inspec/resources/lxc.rb Outdated Show resolved Hide resolved
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos
Copy link
Contributor Author

@Vasu1105 or @clintoncwolfe
Please review the latest changes.

dkumaras and others added 3 commits March 16, 2022 16:44
Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
…ted os

Signed-off-by: Sonu Saha <sonu.saha@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Resources Resources shipped with InSpec. Documentation ZH multi-repo label for the docs-team Expeditor: Bump Minor Version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants