Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFINSPEC-94: Enhance user resource #5959

Merged
merged 22 commits into from
Apr 6, 2022
Merged

CFINSPEC-94: Enhance user resource #5959

merged 22 commits into from
Apr 6, 2022

Conversation

ahasunos
Copy link
Contributor

Signed-off-by: Sonu Saha sonu.saha@progress.com

Related Issue

CFINSPEC-94: Enhance user resource

Description

Using the user resource
Given that the user has called the user resource
then the resource allows to test with new matchers and properties.

New Matchers:

  • belong_to_group
  • belong_to_primary_group
  • have_uid
  • have_home_directory
  • have_login_shell
  • have_authorized_key

New Properties

  • encrypted_password
  • minimum_days_between_password_change
  • maximum_days_between_password_change

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

@ahasunos
CFINSPEC-94: Remove deprecation of has_home_directory? matcher
50fc284 
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos
CFINSPEC-94: Remove deprecation of has_login_shell? matcher
3f294bf 
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos
CFINSPEC-94: Remove deprecation of has_uid? matcher
a0d40a5 
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos
CFINSPEC-94: Remove deprecation of minimum_days_between_password_chan…
978e6ea 
…ge and maximum_days_between_password_change

Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos
CFINSPEC-94: Add new matchers belong_to_group/primary_group
112e8cc 
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos
CFINSPEC-94: Add has_authorized_key for basic unix case
6d46e5a 
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos
CFINSPEC-94: Extend has_authorized_key for windows user
a043008 
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos
CFINSPEC-94: Implement encrypted_password property for linux systems
96103a8 
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos
CFINSPEC-94: encrypted_password works with getent utility on BSD/Solaris
6dfa1e2 
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos
CFINSPEC-94: Clean code, lint check and add comments
d4e49c8 
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos
CFINSPEC-94: Remove old comments that says deprecation for serverspec
95a6ecc 
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos
CFINSPEC-94: Add unit test for introduced matchers and properties
1a5c6c2 
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos
CFINSPEC-94: Add documentation for introduced matchers and properties
8c15ebe 
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos ahasunos requested review from a team as code owners March 28, 2022 23:30
@netlify
Copy link

netlify bot commented Mar 28, 2022 •
edited
Loading

✅ Deploy Preview for chef-inspec ready!

Name Link
🔨 Latest commit 9f78156
🔍 Latest deploy log https://app.netlify.com/sites/chef-inspec/deploys/624d8b6e72854e0009b828bd
😎 Deploy Preview https://deploy-preview-5959--chef-inspec.netlify.app/inspec/resources/user
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the Documentation ZH multi-repo label for the docs-team label Mar 28, 2022
@chef-expeditor
Copy link
Contributor

Hello ahasunos! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@ahasunos ahasunos self-assigned this Mar 29, 2022
@ahasunos ahasunos added the Component: Core Resources Resources shipped with InSpec. label Mar 29, 2022
@ahasunos
CFINSPEC-94: Introduce requested changes after review
2d068be 
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
clintoncwolfe
clintoncwolfe requested changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change the way that you are reading the auth keys file, but otherwise looks pretty good.

lib/inspec/resources/users.rb Outdated Show resolved Hide resolved
lib/inspec/resources/users.rb Outdated Show resolved Hide resolved
lib/matchers/matchers.rb Outdated Show resolved Hide resolved
@ahasunos
CFINSPEC-94: Refactor belongs_to_group
91ffb07 
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos
CFINSPEC-94: Remove user specific matchers from universal matchers & …
5ec479f 
…include in user

Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos
CFINSPEC-94: Add comment on why cat/type is used instead of reading t…
28b92b0 
…he file with inspec.file

Signed-off-by: Sonu Saha <sonu.saha@progress.com>
clintoncwolfe
clintoncwolfe approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dkumaras
doc review
757be4c 
Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
dkumaras
dkumaras reviewed Apr 4, 2022
View reviewed changes
Copy link
Contributor

@dkumaras dkumaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahasunos - please check the suggested review changes and confirm.

@ahasunos
Copy link
Contributor Author

ahasunos commented Apr 4, 2022 •
edited
Loading

@dkumaras It seems you missed to sign-off the commit which is leading to the failure of DCO test.

@dkumaras
formatting edits
8ccdb54 
Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
@dkumaras
formatting edits
9bcaf99 
Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
@dkumaras
Copy link
Contributor

dkumaras commented Apr 5, 2022

ple

@ahasunos , @Vasu1105 , @Nik08 , @clintoncwolfe - I have introduced a new formatting for the parameters value description following a code block. Pls do check and share your thoughts.

@dkumaras
doc review edits
9f78156 
Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
dkumaras
dkumaras reviewed Apr 6, 2022
View reviewed changes
Copy link
Contributor

@dkumaras dkumaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls confirm the changes

@clintoncwolfe clintoncwolfe merged commit 5b6540c into main Apr 6, 2022
@clintoncwolfe clintoncwolfe deleted the ss/enhance-user-resource branch April 6, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkumaras dkumaras dkumaras left review comments

@Vasu1105 Vasu1105 Vasu1105 left review comments

@clintoncwolfe clintoncwolfe clintoncwolfe approved these changes

@Nik08 Nik08 Awaiting requested review from Nik08 Nik08 is a code owner automatically assigned from inspec/inspec-core-team

Assignees

@ahasunos ahasunos

Labels
Component: Core Resources Resources shipped with InSpec. Documentation ZH multi-repo label for the docs-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahasunos @dkumaras @clintoncwolfe @Vasu1105