CFINSPEC-269 Adds resource_id group 8 #6107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for chef-inspec canceled.
|
Vasu1105
force-pushed
the
vasundhara/group8_resource_ids
branch
from
720a5e5
to
ca7b5cf
Compare
Vasu1105
changed the title
ahasunos
reviewed
Jun 6, 2022
lib/inspec/resources/opa_api.rb
Outdated
| @@ -18,6 +24,10 @@ def allow | |||
| @content["result"] | |||
| end | |||
|
|
|||
| def resource_id | |||
| @url | |||
There was a problem hiding this comment.
This might lead to nil error since in line 16 @url is initialized as @url = opts[:url] || nil.
Suggested fix: `@nil || "OPA api"
There was a problem hiding this comment.
Yes but there is validation also below that which does not allow URL as nil.
ahasunos
reviewed
Jun 6, 2022
lib/inspec/resources/opa_cli.rb
Outdated
| @@ -22,6 +28,10 @@ def allow | |||
| @content["result"][0]["expressions"][0]["value"] if @content["result"][0]["expressions"][0]["text"].include?("allow") | |||
| end | |||
|
|
|||
| def resource_id | |||
| "#{@policy}:#{@query}" | |||
There was a problem hiding this comment.
This might lead to nil error too, since in line 17 @policy = opts[:policy] || nil
There was a problem hiding this comment.
Same here there is validation.
Vasu1105
force-pushed
the
vasundhara/group8_resource_ids
branch
2 times, most recently
from
d1a2dc7
to
e02932b
Compare
…_cli resource and unit test for the same Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
Vasu1105
force-pushed
the
vasundhara/group8_resource_ids
branch
from
e02932b
to
5d47334
Compare
clintoncwolfe
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vasu1105 vasundhara.jagdale@chef.io
Description
This adds resource_id for the following resources.
Related Issue
Types of changes
Checklist: