Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes chefstyle #474

Closed

Conversation

Vasu1105
Copy link
Contributor

@Vasu1105 Vasu1105 commented Jul 9, 2019

Signed-off-by: Vasu1105 vasundhara.jagdale@msystechnologies.com

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

Signed-off-by: Vasu1105 <vasundhara.jagdale@msystechnologies.com>
@tas50
Copy link
Contributor

tas50 commented Jul 9, 2019

@Vasu1105

1) Error:
azure transport::azure_client#test_0004_can use azure_client graph client:
NameError: uninitialized constant Azure::GraphRbac
    /home/travis/build/inspec/train/test/unit/transports/azure_test.rb:87:in `block (3 levels) in <top (required)>'
677 runs, 1026 assertions, 0 failures, 1 errors, 0 skips```

@lamont-granquist
Copy link
Contributor

check for :kind_of? in specs needing to be :is_a?

those don't get autofixed by chefstyle.

@Vasu1105
Copy link
Contributor Author

Vasu1105 commented Jul 10, 2019

check for :kind_of? in specs needing to be :is_a?

those don't get autofixed by chefstyle.

@lamont-granquist Did check all files. Looks to be all updated.

@Vasu1105
Copy link
Contributor Author

@Vasu1105

1) Error:
azure transport::azure_client#test_0004_can use azure_client graph client:
NameError: uninitialized constant Azure::GraphRbac
    /home/travis/build/inspec/train/test/unit/transports/azure_test.rb:87:in `block (3 levels) in <top (required)>'
677 runs, 1026 assertions, 0 failures, 1 errors, 0 skips```

@tas50 this is not reproducing locally. Will try to debug.

Signed-off-by: Vasu1105 <vasundhara.jagdale@msystechnologies.com>
@Vasu1105
Copy link
Contributor Author

@tas50 Done the fix for the error.

@tas50
Copy link
Contributor

tas50 commented Jul 19, 2019

This was fixed in #478

@tas50 tas50 closed this Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants