Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #795 - Allowed configuration of the ProtectionDomain #799

Merged
merged 2 commits into from
Jul 3, 2020

Conversation

JonasKunz
Copy link
Member

@JonasKunz JonasKunz commented Jul 3, 2020

Closes #795


This change is Reviewable

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #799 into master will decrease coverage by 0.11%.
The diff coverage is 79.21%.

@@             Coverage Diff              @@
##             master     #799      +/-   ##
============================================
- Coverage     83.00%   82.89%   -0.11%     
- Complexity     1736     1758      +22     
============================================
  Files           174      177       +3     
  Lines          5366     5460      +94     
  Branches        650      658       +8     
============================================
+ Hits           4454     4526      +72     
- Misses          675      691      +16     
- Partials        237      243       +6     
Impacted Files Coverage Δ Complexity Δ
...t/ocelot/config/model/tracing/TracingSettings.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...ion/correlation/log/adapters/Log4J1MDCAdapter.java 70.00% <0.00%> (-7.78%) 4.00 <1.00> (+1.00) ⬇️
...ion/correlation/log/adapters/Log4J2MDCAdapter.java 70.00% <0.00%> (-7.78%) 4.00 <1.00> (+1.00) ⬇️
...tion/correlation/log/adapters/Slf4jMDCAdapter.java 70.00% <0.00%> (-7.78%) 4.00 <1.00> (+1.00) ⬇️
...nstrumentation/context/ContextPropagationUtil.java 84.73% <70.37%> (-3.00%) 31.00 <3.00> (+5.00) ⬇️
...rumentation/context/propagation/DatadogFormat.java 77.14% <77.14%> (ø) 7.00 <7.00> (?)
...trumentation/context/PropagationFormatManager.java 80.00% <80.00%> (ø) 3.00 <3.00> (?)
...ocelot/config/model/tracing/PropagationFormat.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...ore/instrumentation/correlation/log/MDCAccess.java 87.50% <100.00%> (+3.63%) 16.00 <3.00> (+3.00)
.../core/instrumentation/injection/ClassInjector.java 95.24% <100.00%> (+0.50%) 20.00 <4.00> (+2.00)
... and 8 more

Copy link
Member

@mariusoe mariusoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mariusoe mariusoe merged commit e03c0f5 into inspectIT:master Jul 3, 2020
@mariusoe mariusoe mentioned this pull request Jul 3, 2020
@JonasKunz JonasKunz deleted the protection-domain-fix branch July 3, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the ProtectionDomain of injected Classes configurable.
2 participants