hep_schema: known categories are now enums #23
Conversation
david-caro
force-pushed
the
workflow_fixes
branch
from
4993241
to
f130acb
Compare
|
Waiting to resolve current logging issues on record migration on nightly so we will have insight on what this breaks on the current records there. |
|
Actually, we can merge this, as we are using semantic versioning, this will not get deployed on nightly until we change the requirements on inspire-next :) |
| "enum": [ | ||
| "INSPIRE", | ||
| "submitter", | ||
| "conference", | ||
| "curator", | ||
| "publisher", | ||
| "arxiv", | ||
| "pos", | ||
| "asp", |
There was a problem hiding this comment.
PoS = Proceedings of science
ASP is a typo, it should be aps -> American Physical Society
Essentially, two spiders that we already have that use this.
| "properties": { | ||
| "scheme": { | ||
| "type": "string", | ||
| "enum": ["INSPIRE"] |
There was a problem hiding this comment.
Mh, maybe we should add something like prettifyjson to this repo.
There was a problem hiding this comment.
I don't care much, what would it improve?
There was a problem hiding this comment.
Found an easy way to pretiffy all json, sent a new patch with a script for it + pretified everything with it :)
There was a problem hiding this comment.
Hmmm... I'll add a test for it too so we don't forget pretifying at the end, maybe even a hook-like script to add to the git before commit or something might work too...
| @@ -1,182 +1,172 @@ | |||
| { | |||
There was a problem hiding this comment.
Maybe I misunderstood how you meant to use your generate_records script, but here IMO it would be better to only have the changes about the thing that you really changed, rather than a completely new record...
There was a problem hiding this comment.
Well, these examples are meant to be to ensure backwards compatibility, so you should not use them to see what has changed. To see the changes you should look to the schema itself.
I agree though that it would be a plus to have the scripts regenerate only the portions that changed, but I see no easy way to do it (that does not involve some non-trivial programming on the ugly js script).
For now I just regenerate the whole lot each time to make sure it's maintained complete.
* INCOMPATIBLE ARXIV and INSPIRE scheme categories have now enums with valid options. * Other scheme types (APS and POS) can have any values, but no other schemes are allowed. * Updated tests fixtures to adapt to the new schema changes. * Fixed issue on the example generator script to allow intra-schema references. Signed-off-by: David Caro <david@dcaro.es>
* Also pretified all the existings jsons. Signed-off-by: David Caro <david@dcaro.es>
david-caro
force-pushed
the
workflow_fixes
branch
from
f130acb
to
f879689
Compare
Signed-off-by: David Caro <david@dcaro.es>
|
Let's merge this, it will not break anything on inspire-next, but allows testing the related changes on hepcrawl. |
options.
schemes are allowed.
Signed-off-by: David Caro david@dcaro.es