Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

institutions: add GRID to external system identifiers #337

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

vbalbp
Copy link
Contributor

@vbalbp vbalbp commented Nov 12, 2018

Signed-off-by: Victor Balbuena vbalbp@gmail.com

@ghost ghost assigned vbalbp Nov 12, 2018
@ghost ghost added the Review: WIP label Nov 12, 2018
@vbalbp
Copy link
Contributor Author

vbalbp commented Nov 12, 2018

Based on examples found on INSPIRE:

1. | grid.268323.e
2. | grid.1008.9
3. | grid.38142.3c
4. | grid.170205.1
5. | grid.412151.2
6. | grid.451133.1
7. | grid.57686.3a
8. | grid.440662.2

I think this ^grid\.\d+\.\d\w?$ makes sense as a regular expression for the GRID identifier.

@vbalbp vbalbp requested a review from michamos November 12, 2018 14:03
@michamos
Copy link
Contributor

apparently the last part is hexadecimal: look at the regex in https://www.wikidata.org/wiki/Property:P2427. I could not find any reliable source for that regex, so maybe relax it to ^grid\.\d+\.\w+$.

required:
- schema
- value
title: HAL identifier
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong title

@vbalbp
Copy link
Contributor Author

vbalbp commented Nov 12, 2018

On the same webpage that you linked, there is a section called format as a regular expression which uses this expression: grid\.\d{4,6}\.[0-9a-f]{1,2}.
I think it would make sense to use it instead?

Signed-off-by: Victor Balbuena <vbalbp@gmail.com>
@michamos michamos merged commit 1dbab64 into inspirehep:master Nov 12, 2018
@ghost ghost removed the Review: WIP label Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants