Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename elastic_cache to elasticache to fix a behaviour change in Click 7.0 #7

Merged
merged 4 commits into from
Oct 9, 2018

Conversation

KevinGreen
Copy link
Contributor

@KevinGreen KevinGreen commented Oct 9, 2018

This is causing CWAM runs to fail because the command name changed with the latest version of Click, the library used for cli generation.

Link to the original issue: https://bugs.instacart.tools/issues/10282

@KevinGreen KevinGreen requested a review from a team October 9, 2018 21:32
@KevinGreen KevinGreen requested review from a team and removed request for a team October 9, 2018 21:53
Copy link

@nickelser nickelser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@Matt-Hurd Matt-Hurd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you provide a link to the complaints from users?

@KevinGreen
Copy link
Contributor Author

Added a link to the ticket in the description

@KevinGreen KevinGreen merged commit fd724bd into master Oct 9, 2018
@KevinGreen KevinGreen deleted the kevin/cwam-version-bump branch October 9, 2018 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants