Update AGP 8 #300
Update AGP 8 #300
Conversation
| classpath "com.vanniktech:gradle-android-junit-jacoco-plugin:0.16.0" | ||
| // We need to fork the plugin to fix an incorrect usage of tasks.withType(Test) | ||
| // https://github.com/vanniktech/gradle-android-junit-jacoco-plugin/compare/master...Laimiux:gradle-android-junit-jacoco-plugin:laimonas/gradle-8?expand=1 | ||
| classpath("com.github.Jawnnypoo:gradle-android-junit-jacoco-plugin:61a9cc0129") |
There was a problem hiding this comment.
Fork in order to support publishing on Jitpack. Hoping that we can see vanniktech/gradle-android-junit-jacoco-plugin#219 get merged and won't have to worry about this anymore.
There was a problem hiding this comment.
I don't think we publish to Jitpack anymore
There was a problem hiding this comment.
Sorry yeah, that was confusing wording. I forked your fork of gradle-android-junit-jacoco-plugin so that I could change configuration of that lib to publish it to Jitpack, since it was configured to publish to IC's internal artifactory server, and was failing to build on Jitpack.
| @@ -16,12 +16,12 @@ import io.reactivex.rxjava3.core.Observable | |||
| * @param bind A bind function connects state observable to the view rendering. | |||
| * @param lifecycleCallbacks Optional lifecycle callbacks if you need to know the Fragment state. | |||
| */ | |||
| class FeatureView<RenderModel>( | |||
| class FeatureView<RenderModel : Any>( | |||
There was a problem hiding this comment.
It would not compile without adding this in various places, unfortunately. I believe this stems from RxJava (hence why I updated the dependency) but I am not 100% sure.
|
Really awesome, I was just thinking that we need to update Gradle. One thing that constantly breaks with Gradle updates is the maven publishing plugin. Could you verify that publish to artifactory and to maven still run correctly? |
|
Yes, good call 👍 |
|
Covered by #324 |
Did this when trying to explore some issues with R8 full mode.