Refactor FeatureFactory public API using Params. #398
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I'm wrapping the
dependencies
andkey
into aParams
object and updatingFeatureFactory.initialize
to get it via the extension function receiver typeParams.initialize(): Feature
.Feature factory initialization changes from
to
Why
We need to pass
FragmentId
or something equivalent to theFeatureFactory
. This change requires us to introduce a new parameter that would break existing usages. Instead of just adding a new parameter, I'm refactoring the way this public API works which will enable us to modifyParams
object in the future without breaking the usages.