Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to add 1 to N batches & 1 to N concentrations within the box #1732

Closed
diegoliberman opened this issue Jun 22, 2022 — with Manas.Tech Commit · 3 comments
Closed
Assignees

Comments

Copy link
Contributor

diegoliberman commented Jun 22, 2022

Basically, we need to allow defining what batches will be used, and for each batch what concentrations.

Fields:

  1. Batch: autocomplete
  2. Instructions (free text field)
  3. Distractor (check box)
  4. Concentrations
    1. Number of replicates (numeric, integer)
    2. Concentration (numeric, float)

Acceptance criteria

  1. I can select the option Create new samples and then do any of the following
  2. I can define any number of batches within the box
  3. For each batch I can define instructions
  4. For each batch I can define if it's a distractor
  5. For each batch I can define N concentrations
  6. For each concentration I can define the number of replicates
  7. For each concentration I can define its value in copies/ml
  8. I can see a list of the concentrations I've already added
  9. I can see a list of the batches that I've already added

Note

  1. Saving the box is not part of the scope of this ticket, here we are only pursuing achieving a good UX.
  2. The Distractor field is a new attribute for the Samples. It should be added in the sample's form and it should be blinded along the other blinded fields. It was added into the invision designs. The checkbox text is When enabled, the system will consider that its result should be negative regardless of its concentration and the defined threshold.

Invision

  1. Create new samples
  2. Add batches and concentrations
@diegoliberman diegoliberman changed the title Allow to add 1 to N batches within the box Allow to add 1 to N batches & 1 to N concentrations \within the box Jun 22, 2022
@diegoliberman diegoliberman changed the title Allow to add 1 to N batches & 1 to N concentrations \within the box Allow to add 1 to N batches & 1 to N concentrations within the box Jun 22, 2022
@omelao
Copy link
Contributor

omelao commented Nov 9, 2022

When I add batches: won’t be the samples created on database yet? Just when I save it?

@diegoliberman
Copy link
Contributor Author

Correct, the samples will be created in the database when the user presses the Save button. Not earlier. At least not for now.

@sardar-usman
Copy link

@leandroradusky It is working fine as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants