Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to save a box of samples to be created #1733

Closed
diegoliberman opened this issue Jun 22, 2022 — with Manas.Tech Commit · 3 comments
Closed

Allow to save a box of samples to be created #1733

diegoliberman opened this issue Jun 22, 2022 — with Manas.Tech Commit · 3 comments
Assignees

Comments

Copy link
Contributor

diegoliberman commented Jun 22, 2022

After capturing the input with #1732, now this ticket is for handling the save action and basically create the configured samples, and save the box associating all the samples that were created.

Acceptance criteria

  1. After saving a box that creates samples, I can do any of the following
  2. I can find the box in the list of boxes
  3. I can see the box detail as designed here.
  4. I can find the samples that were created in the box detail and in the list of samples
  5. I can transfer the box
@omelao
Copy link
Contributor

omelao commented Nov 9, 2022

#1733 will handle the save just for #1732? What about #1731?

What happens when I add a new batch? Won't it be created on database?

@diegoliberman
Copy link
Contributor Author

I understand that #1731 will be straight forward, as is just porting a feature that already exists. That's why I considered saving the box as part of itself (see acceptance criteria number 3).

I also understand that #1732 will be more difficult and I want to clearly feel progress, that's why I'm proposing to split it in 2 tickets. With #1732 the saving of the box will need to consider many more things: creating samples, reading many UI inputs and processing it.

Finally, you can only add existing batches to the box. As it works today. We can't allow to define non-existing batches, because the batch attributes are needed for configuring the samples that are created. So it wouldn't be easy to offer a nice UX that allows creating batches while creating a box.

@sardar-usman
Copy link

@omelao It's working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants