Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recover inventory ordering #1768

Closed
diegoliberman opened this issue Oct 24, 2022 — with Manas.Tech Commit · 1 comment · Fixed by #1779
Closed

Recover inventory ordering #1768

diegoliberman opened this issue Oct 24, 2022 — with Manas.Tech Commit · 1 comment · Fixed by #1779
Assignees
@leandroradusky

Comments

@diegoliberman Manas.Tech Commit
Copy link
Contributor

No description provided.

@leandroradusky leandroradusky self-assigned this Nov 3, 2022
leandroradusky added a commit that referenced this issue Nov 3, 2022
@leandroradusky
Recovered pertinent specs (#1767) and checked that inventory is prope…
8784358 
…rly ordered (#1768)
@leandroradusky leandroradusky mentioned this issue Nov 3, 2022
Merged
leandroradusky added a commit that referenced this issue Nov 7, 2022
@leandroradusky
Simplify boxes transfer blinding flow - Stage 1 (#1779)
a011682 
* Reverted changes of PR #1746

* Fix broken test

* Recovered pertinent specs (#1767) and checked that inventory is properly ordered (#1768)

* Remove tests that don't apply
@ysbaddaden ysbaddaden linked a pull request Nov 14, 2022 that will close this issue
Simplify boxes transfer blinding flow - Stage 1 #1779
Merged
@diegoliberman
Copy link
Contributor Author

Test instructions:

  1. If the box is unblinded, when downloading the inventory and printing the box labels, the order of the samples is by Batch, Concentration and finally replicate.
  2. If the box is blinded, the order is by UUID.

The actual goal of changing the order is that by sorting by UUID, the user can't figure out what the blinded attributes are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leandroradusky leandroradusky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify boxes transfer blinding flow - Stage 1 instedd/cdx
2 participants
@leandroradusky @diegoliberman