Setup Standard and Rubocop #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ysbaddaden
reviewed
May 2, 2023
There was a problem hiding this comment.
That looks very nice 👍
A GitHub action to run Rubocop and it would be perfect.
Any cop that is merely about style could be enabled right now and autocorrected. As long as we have two distinct commits for the configuration then the autocorrection, we can fix the pending pull requests (cherry-pick the configuration, autocorrect, commit).
like that ? |
ysbaddaden
reviewed
May 2, 2023
ysbaddaden
reviewed
May 11, 2023
ysbaddaden
approved these changes
May 11, 2023
Fix: bundle exec rubocop instead of bin/rubocop Call lint command in docker container Add Lint Job Add rubocop action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration files for Standard and Rubocop gems