Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI glitches in the settings of roles and policies #1785 #1937

Merged
merged 1 commit into from
May 15, 2023
Merged

Fix UI glitches in the settings of roles and policies #1785 #1937

merged 1 commit into from
May 15, 2023

Conversation

bolom
Copy link
Contributor

@bolom bolom commented May 10, 2023

This PR fix UI glitches in the settings of roles and policies described in #1785

How to test ?

  1. WIth an admin user, go tot he settings menu
  2. Go to the Roles section
  3. Access the role detail page for any role
  4. Click on a policy
  5. Scroll down to the bottom without any problem

@bolom bolom linked an issue May 10, 2023 that may be closed by this pull request
Fix UI glitches in the settings of roles and policies #1785
Closed
@bolom bolom self-assigned this May 10, 2023
@bolom bolom requested a review from leandroradusky May 10, 2023 19:09
leandroradusky
leandroradusky approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@leandroradusky leandroradusky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested and works well!

:)

@bolom bolom merged commit 57f847f into main May 15, 2023
@bolom bolom deleted the 1785-fix-ui-glitches-in-the-settings-of-roles-and-policies branch May 15, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandroradusky leandroradusky leandroradusky approved these changes

Assignees

@bolom bolom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix UI glitches in the settings of roles and policies
2 participants
@bolom @leandroradusky