Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#74: Trust proxy headers in live environments #75

Merged
merged 2 commits into from
Jun 4, 2020
Merged

#74: Trust proxy headers in live environments #75

merged 2 commits into from
Jun 4, 2020

Conversation

pyritewolf
Copy link
Contributor

closes #74

What a ride

For the record:

  • Starlette has some pretty disturbing issues handling requests behind a proxy
  • Fortunately, the proxy we're using in Rancher sets all the proper headers, so we hooked up to Uvicorn's middleware to ensure requests go out the same way they came in

@pyritewolf pyritewolf added the bug Something isn't working label Jun 4, 2020
@pyritewolf pyritewolf self-assigned this Jun 4, 2020
matiasgarciaisaia
matiasgarciaisaia approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@matiasgarciaisaia matiasgarciaisaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short & sweet 👍

@pyritewolf pyritewolf merged commit 7995a97 into master Jun 4, 2020
@yls00 yls00 deleted the bug/74-https branch August 5, 2020 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasgarciaisaia matiasgarciaisaia matiasgarciaisaia approved these changes

Assignees

@pyritewolf pyritewolf

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP/HTTPS mixed content bug
2 participants
@pyritewolf @matiasgarciaisaia