Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): use explicit endpoint URL #190

Merged
merged 1 commit into from
Oct 3, 2023
Merged

chore(api): use explicit endpoint URL #190

merged 1 commit into from
Oct 3, 2023

Conversation

pinglin
Copy link
Member

@pinglin pinglin commented Oct 2, 2023

Because

  • the API design has been changed quite a lot

This commit

  • adopt the latest Instill Core API

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0a0f124) 51.72% compared to head (597287e) 51.58%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
- Coverage   51.72%   51.58%   -0.15%     
==========================================
  Files          61       61              
  Lines        4887     4872      -15     
==========================================
- Hits         2528     2513      -15     
  Misses       2064     2064              
  Partials      295      295              
Flag Coverage Δ
unittests 51.58% <100.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/cmd/api/api.go 70.17% <100.00%> (-1.22%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pinglin pinglin merged commit 4a92826 into main Oct 3, 2023
17 checks passed
@pinglin pinglin deleted the pinglin/fix-api branch October 3, 2023 00:41
pinglin added a commit that referenced this pull request Oct 4, 2023
Because

- the API design has been changed quite a lot

This commit

- adopt the latest Instill Core API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants